Fix: breaking changes with GroupCall and ensure backwards-compatibility #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure group call backwards-compatibility and move `allowCallWithoutVideoAndAudio`to the end of the `CroupCall` constructor
robintown
approved these changes
Mar 2, 2023
EnricoSchw
added
T-Deprecation
EnricoSchw
deleted the
enricoschw/fix-to-ensure-group-call-backwards-compatibility
branch
t3chguy
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure group call backwards-compatibility and move
allowCallWithoutVideoAndAudioto the end of theCroupCallconstructorThe changes in PR Enable group calls without video and audio track by configuration of MatrixClient #3162 (comment) brakes with the
matrix-react-sdkbecause of using GroupCall there: https://github.com/matrix-org/matrix-react-sdk/blob/2d2b40ddac5fa1adb12b34eea436e0b70e8a9857/src/models/Call.ts#L723The changes in PR
3162leads to breaking dependencies: https://github.com/matrix-org/matrix-react-sdk/actions/runs/4316690112/jobs/7532790787This PR is a fix for it.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.