Pull out a public CryptoApi
#3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that we don't have to implement annoying shims in `MatrixClient`
|
more tests are in #3203 |
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards fixing element-hq/element-web#17488. We create a new
CryptoApiwhich is a subset ofCryptoBackend, and defines the crypto interfaces which are meant to be used directly by applications.Obviously, this is just a very initial step: in time we'll need to more all the crypto-related functions from
MatrixClientin here. But some of those are likey to change signature slightly, or not be supported at all, as we move to the Rust SDK, and I only want to add things toCryptoApionce we're reasonably sure that it represents the final API shape.This change is marked as an internal change (Task), so will not be included in the changelog.