Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MSC3882 revision 1 #3228

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Support for MSC3882 revision 1 #3228

merged 4 commits into from
Apr 5, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Mar 24, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@hughns
Copy link
Member Author

hughns commented Mar 24, 2023

The code smells reported by SonarCloud are for usage of a newly deprecated field and enum value that are used to provide compatibility until the deprecated field is removed. As such, I believe this check failure can be overruled.

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@hughns hughns enabled auto-merge April 5, 2023 15:16
@hughns hughns added this pull request to the merge queue Apr 5, 2023
Merged via the queue into develop with commit 59784aa Apr 5, 2023
@hughns hughns deleted the hughns/msc3882-r1 branch April 5, 2023 17:32
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 25, 2023
* Change `Store.save()` to return a `Promise` ([\matrix-org#3221](matrix-org#3221)). Contributed by @texuf.
* Add typedoc-plugin-mdn-links ([\matrix-org#3292](matrix-org#3292)).
* Annotate events with executed push rule ([\matrix-org#3284](matrix-org#3284)). Contributed by @kerryarchibald.
* Element-R: pass device list change notifications into rust crypto-sdk ([\matrix-org#3254](matrix-org#3254)). Fixes element-hq/element-web#24795. Contributed by @florianduros.
* Support for MSC3882 revision 1 ([\matrix-org#3228](matrix-org#3228)). Contributed by @hughns.
* Fix screen sharing on Firefox 113 ([\matrix-org#3282](matrix-org#3282)). Contributed by @tulir.
* Retry processing potential poll events after decryption ([\matrix-org#3246](matrix-org#3246)). Fixes element-hq/element-web#24568.
* Element-R: handle events which arrive before their keys ([\matrix-org#3230](matrix-org#3230)). Fixes element-hq/element-web#24489.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants