Add the call object to Call events #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in the comment. I've added it to the end so this should be completely backwards compatible (although it would be much nicer if it were the first arg, probably).
So it doesn't clash with the call error event
Otherwise we won't get far enough to test the right part
robintown
approved these changes
Mar 28, 2023
|
I've added a number of tests to up the code coverage here. This PR makes tiny changes to the event emitters which of course cover a wide range of the codebase, some of which just lacks tests. One in particular I've added a comment to mark it for potential removal because I can't see where the event emitter would actually be triggered. It's still not quite at the 80% level but hopefully this at least demonstrates the spirit of going in the right direction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the comment. I've added it to the end so this should be completely backwards compatible (although it would be much nicer if it were the first arg, probably).
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.