Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export type for return of getCapabilities() #3266

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Export type for return of getCapabilities() #3266

merged 4 commits into from
Apr 6, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Apr 6, 2023 •
edited by github-actions bot
Loading

Renamed because it clashes with ICapabilities from embedded. I would happily take alternative naming suggestions.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@hughns
Export type for return of getCapabilities()
9a6a5ec 
Renamed because it clashes with ICapabilities from embedded
@hughns hughns added the T-Task Tasks for the team like planning label Apr 6, 2023
@hughns
Export type for return of getCapabilities()
5ee3a4b 
Renamed because it clashes with ICapabilities from embedded
@hughns hughns force-pushed the hughns/expose-capabilities-type branch from 9a6a5ec to 5ee3a4b Compare April 6, 2023 08:21
@hughns hughns marked this pull request as ready for review April 6, 2023 08:36
@hughns hughns requested a review from a team as a code owner April 6, 2023 08:36
@hughns hughns requested review from t3chguy and justjanne April 6, 2023 08:36
@hughns hughns mentioned this pull request Apr 6, 2023
Merged
3 tasks
t3chguy
t3chguy approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're renaming it can we drop the I prefix, we stopped doing that a while ago

@hughns hughns requested a review from t3chguy April 6, 2023 11:25
@hughns hughns added this pull request to the merge queue Apr 6, 2023
Merged via the queue into develop with commit 3d1a450 Apr 6, 2023
@hughns hughns deleted the hughns/expose-capabilities-type branch April 6, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughns @t3chguy