Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to receipt timestamp if we have no event (js-sdk part) #3400

Closed

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented May 24, 2023

There is similar logic in matrix-react-sdk, so we change that in matrix-org/matrix-react-sdk#10974

Part of element-hq/element-web#10954


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fall back to receipt timestamp if we have no event (js-sdk part) (#3400). Contributed by @andybalaam.

@andybalaam andybalaam changed the title Fall back to receipt timestamp if we have no event Fall back to receipt timestamp if we have no event (js-sdk part) May 24, 2023
@andybalaam
Copy link
Contributor Author

Not doing this for now because:

  1. The problem I am finding right now is to do with stuck unreads, whereas this is about notifs, so Fall back to receipt timestamp if we have no event (react-sdk part) matrix-react-sdk#10974 is more relevant
  2. With any luck, the homeserver will give us the correct count for notifs, so if we make sure we believe that, it may be more effective than guessing as we are here
  3. If we do want to guess within matrix-js-sdk, we should return an enum with e.g. Read, Unread, ProbablyUnread, ProbablyRead or similar to be clear that we are using heuristics.

@andybalaam andybalaam closed this May 26, 2023
@andybalaam andybalaam deleted the andybalaam/fall-back-to-receipt-timestamp branch May 26, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant