Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend stats summary with call device and user count based on room state #3424

Merged
merged 56 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
82303b9
send expected peer connections to posthog.
toger5 May 30, 2023
91dfdd4
add tests
toger5 May 31, 2023
538b787
change GroupCallStats initialized
toger5 May 31, 2023
0bc2bfd
prettier
toger5 May 31, 2023
dd21ee2
more test and catch for promise
toger5 May 31, 2023
d383d2d
Merge branch 'develop' into splitBrainIndicatorRoomState
toger5 May 31, 2023
b23b8fd
seperate the participant logic in a summary extend function
toger5 Jun 1, 2023
45e8ae4
remove unused
toger5 Jun 2, 2023
2c512c8
Merge branch 'develop' into splitBrainIndicatorRoomState
toger5 Jun 2, 2023
1b42313
rename summaryStatsReportGatherer to "Reporter"
toger5 Jun 2, 2023
1f99cd0
review
toger5 Jun 5, 2023
c4e3b90
Update src/webrtc/stats/groupCallStats.ts
toger5 Jun 5, 2023
39465e3
revert rename
toger5 Jun 7, 2023
0fd11ac
Update all non-major dependencies (#3433)
renovate[bot] Jun 2, 2023
600f26d
Update definitelyTyped (#3430)
renovate[bot] Jun 2, 2023
de34d24
Export FALLBACK_ICE_SERVER (#3429)
t3chguy Jun 2, 2023
6b60287
Add an integration test for verification (#3436)
richvdh Jun 2, 2023
44ed483
Always show a summary after Jest tests (#3440)
richvdh Jun 2, 2023
dd23e4b
Use correct /v3 prefix for /refresh (#3016)
davidisaaclee Jun 3, 2023
5976d69
Update Mutual Rooms (MSC2666) support (#3381)
ShadowJonathan Jun 5, 2023
3895fbb
GHA: build and cypress-test a copy of element-web after each push (#3…
richvdh Jun 5, 2023
6f79cd2
Fix downstream-artifacts build (#3443)
richvdh Jun 5, 2023
1e2f701
Fix edge cases around 2nd order relations and threads (#3437)
t3chguy Jun 5, 2023
d4e3452
Make sliding sync linearize processing of sync requests (#3442)
t3chguy Jun 5, 2023
8ccbb8d
Disable downstream artifacts build for develop branch (#3444)
richvdh Jun 5, 2023
e1ce16a
Export thread-related types from SDK (#3447)
stas-demydiuk Jun 6, 2023
a21736c
Integration test for QR code verification (#3439)
richvdh Jun 6, 2023
9afad10
Add `getShowSasCallbacks`, `getShowQrCodeCallbacks` to VerifierBase (…
richvdh Jun 6, 2023
2c94bae
Fix changelog_head.py script to be Python 3 compatible
RiotRobot May 16, 2023
8bab6cd
Prepare changelog for v25.2.0-rc.1
RiotRobot May 16, 2023
1aeaba5
v25.2.0-rc.1
RiotRobot May 16, 2023
b0a73fc
Fix tsconfig-build.json
RiotRobot May 16, 2023
ec3fd91
Prepare changelog for v25.2.0-rc.2
RiotRobot May 16, 2023
1c67b38
v25.2.0-rc.2
RiotRobot May 16, 2023
a3c1656
Fix docs deployment
t3chguy May 16, 2023
6969446
Prepare changelog for v25.2.0-rc.3
RiotRobot May 16, 2023
9a79554
v25.2.0-rc.3
RiotRobot May 16, 2023
6ad2cc3
Prepare changelog for v25.2.0-rc.4
RiotRobot May 16, 2023
4c250b5
v25.2.0-rc.4
RiotRobot May 16, 2023
a8b327e
[Backport staging] Attempt a potential workaround for stuck notifs (#…
RiotRobot May 19, 2023
e255bab
Prepare changelog for v25.2.0-rc.5
RiotRobot May 19, 2023
bf107ac
v25.2.0-rc.5
RiotRobot May 19, 2023
e53368a
[Backport staging] Fix mark as unread button (#3401)
RiotRobot May 24, 2023
29b9889
Prepare changelog for v26.0.0-rc.1
RiotRobot Jun 1, 2023
144edca
v26.0.0-rc.1
RiotRobot Jun 1, 2023
e7a02b0
Prepare changelog for v26.0.0
RiotRobot Jun 6, 2023
3e1b3d9
v26.0.0
RiotRobot Jun 6, 2023
4c219cf
Resetting package fields for development
RiotRobot Jun 6, 2023
accd4a5
use cli.canSupport to determine intentional mentions support (#3445)
Jun 6, 2023
0fcfe9c
git fixup
toger5 Jun 7, 2023
4c09840
import updates
toger5 Jun 7, 2023
dd58296
merge with develop
toger5 Jun 7, 2023
7a19ddf
dont revert enricos change
toger5 Jun 7, 2023
d2c8b04
temp rename for lowercase
toger5 Jun 7, 2023
1eb1fdb
lowercase
toger5 Jun 7, 2023
ce5e00f
Merge branch 'develop' into toger5/splitbrainIndicatorRoomState
toger5 Jun 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions spec/test-utils/webrtc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -745,3 +745,78 @@ export const REMOTE_SFU_DESCRIPTION =
"a=sctp-port:5000\n" +
"a=ice-ufrag:obZwzAcRtxwuozPZ\n" +
"a=ice-pwd:TWXNaPeyKTTvRLyIQhWHfHlZHJjtcoKs";

export const groupCallParticipantsFourOtherDevices = new Map([
[
new RoomMember("roomId0", "user1"),
new Map([
[
"deviceId0",
{
sessionId: "0",
screensharing: false,
},
],
[
"deviceId1",
{
sessionId: "1",
screensharing: false,
},
],
[
"deviceId2",
{
sessionId: "2",
screensharing: false,
},
],
]),
],
[
new RoomMember("roomId0", "user2"),
new Map([
[
"deviceId3",
{
sessionId: "0",
screensharing: false,
},
],
[
"deviceId4",
{
sessionId: "1",
screensharing: false,
},
],
]),
],
]);

export const groupCallParticipantsOneOtherDevice = new Map([
[
new RoomMember("roomId1", "thisMember"),
new Map([
[
"deviceId0",
{
sessionId: "0",
screensharing: false,
},
],
]),
],
[
new RoomMember("roomId1", "opponentMember"),
new Map([
[
"deviceId1",
{
sessionId: "1",
screensharing: false,
},
],
]),
],
]);
8 changes: 8 additions & 0 deletions spec/unit/webrtc/stats/groupCallStats.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ limitations under the License.
*/
import { GroupCallStats } from "../../../../src/webrtc/stats/groupCallStats";
import { CallStatsReportSummary } from "../../../../src/webrtc/stats/callStatsReportSummary";
import { groupCallParticipantsOneOtherDevice } from "../../../test-utils/webrtc";

const GROUP_CALL_ID = "GROUP_ID";
const LOCAL_USER_ID = "LOCAL_USER_ID";
Expand Down Expand Up @@ -160,6 +161,13 @@ describe("GroupCallStats", () => {
expect(clearInterval).not.toHaveBeenCalled();
});
});

describe("on setting participants", () => {
it("should return the same participants", async () => {
stats.setParticipants(groupCallParticipantsOneOtherDevice);
expect(stats.getParticipants()).toBe(groupCallParticipantsOneOtherDevice);
});
});
});

const mockRTCPeerConnection = (): RTCPeerConnection => {
Expand Down
Loading