ElementR: Add CryptoApi.getCrossSigningStatus
#3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
changed the title
crypto.getCrossSigningStatuscrypto.getCrossSigningStatus
10 tasks
Merged
3 tasks
florianduros
changed the title
crypto.getCrossSigningStatusCryptoApi.getCrossSigningStatus
richvdh
requested changes
Jun 7, 2023
richvdh
requested changes
Jun 8, 2023
| fetchMock.get("express:/_matrix/client/r0/user/:userId/account_data/:type", {}); | ||
|
|
||
| // we expect a request to upload signatures for our device ... | ||
| fetchMock.post({ url: "path:/_matrix/client/v3/keys/signatures/upload", name: "upload-sigs" }, {}); |
There was a problem hiding this comment.
I think we need to document these endpoint names, in the doc-comments for mockCrossSigningRequest. They form part of the interface of those functions, which the test is relying on.
There was a problem hiding this comment.
to be clear, by "endpoint names", I mean things like upload-sigs.
|
I'm adding new tests for the new |
richvdh
requested changes
Jun 9, 2023
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Feb 22, 2024
* Introduce a new `Crypto.Verifier` interface, and deprecate direct access to `VerificationBase`, `SAS` and `ReciprocateQRCode` ([\matrix-org#3414](matrix-org#3414)). * Add `rust-crypto#isCrossSigningReady` implementation ([\matrix-org#3462](matrix-org#3462)). Contributed by @florianduros. * OIDC: Validate `m.authentication` configuration ([\matrix-org#3419](matrix-org#3419)). Contributed by @kerryarchibald. * ElementR: Add `CryptoApi.getCrossSigningStatus` ([\matrix-org#3452](matrix-org#3452)). Contributed by @florianduros. * Extend stats summary with call device and user count based on room state ([\matrix-org#3424](matrix-org#3424)). Contributed by @toger5. * Update MSC3912 implementation to use `with_rel_type` instead of `with_relations` ([\matrix-org#3420](matrix-org#3420)). * Export thread-related types from SDK ([\matrix-org#3447](matrix-org#3447)). Contributed by @stas-demydiuk. * Use correct /v3 prefix for /refresh ([\matrix-org#3016](matrix-org#3016)). Contributed by @davidisaaclee. * Fix thread list being ordered based on all updates ([\matrix-org#3458](matrix-org#3458)). Fixes element-hq/element-web#25522. * Fix: handle `baseUrl` with trailing slash in `fetch.getUrl` ([\matrix-org#3455](matrix-org#3455)). Fixes element-hq/element-web#25526. Contributed by @kerryarchibald. * use cli.canSupport to determine intentional mentions support ([\matrix-org#3445](matrix-org#3445)). Fixes element-hq/element-web#25497. Contributed by @kerryarchibald. * Make sliding sync linearize processing of sync requests ([\matrix-org#3442](matrix-org#3442)). * Fix edge cases around 2nd order relations and threads ([\matrix-org#3437](matrix-org#3437)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
UserIdentityandOwnUserIdentitymatrix-rust-sdk#2020CryptoApi.getCrossSigningStatusAPI which is returning the current state of the cross signing for the current deviceHere's what your changelog entry will look like:
✨ Features
CryptoApi.getCrossSigningStatus(#3452). Contributed by @florianduros.