Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: speed up slow unit test #3492

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 20, 2023

A couple of tests were waiting for a request that wasn't happening, so timing out after 1.5 seconds. Let's avoid the extra slowth.

(This was introduced by changes in #3487, but the changes in this PR do no harm anyway)


This change is marked as an internal change (Task), so will not be included in the changelog.

A couple of tests were waiting for a request that wasn't happening, so timing
out after 1.5 seconds. Let's avoid the extra slowth.

(This was introduced by changes in
#3487, but the changes in this
PR do no harm anyway)
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh added this pull request to the merge queue Jun 22, 2023
Merged via the queue into develop with commit e8c89e9 Jun 22, 2023
28 of 29 checks passed
@richvdh richvdh deleted the rav/element-r/24_speed_up_test branch June 22, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants