Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve integration test for interactive verification #3495

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Improve integration test for interactive verification #3495

merged 7 commits into from
Jun 23, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 20, 2023 •
edited by github-actions bot
Loading

  • test more things
  • make it better match the spec

Suggest reviewing commit-by-commit, and turning off whitespace diffs.

This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh richvdh requested a review from a team as a code owner June 20, 2023 15:15
@richvdh richvdh added the T-Task Tasks for the team like planning label Jun 20, 2023
@richvdh richvdh mentioned this pull request Jun 20, 2023
Merged
@richvdh richvdh changed the title Improve intetration test for interactive verification Improve integration test for interactive verification Jun 20, 2023
weeman1337
weeman1337 reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks for digging into it and documenting it 👍

Found one potential bit that may introduce flakyness.

spec/integ/crypto/verification.spec.ts Outdated Show resolved Hide resolved
@richvdh richvdh requested a review from weeman1337 June 23, 2023 12:37
@richvdh richvdh added this pull request to the merge queue Jun 23, 2023
Merged via the queue into develop with commit f884c78 Jun 23, 2023
@richvdh richvdh deleted the rav/element-r/23.1_improve_verification_test branch June 23, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @weeman1337