Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: Store cross signing keys in secret storage #3498

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jun 21, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)
  • Move helper functions out of the cross-signing.spec.ts in order to bootstrap the cross signing in other test suite
  • Store cross signing keys in secret storage

Here's what your changelog entry will look like:

✨ Features

  • Element-R: Store cross signing keys in secret storage (#3498). Contributed by @florianduros.

@florianduros florianduros changed the title ElementR: Store cross signing keys in secret storage Element-R: Store cross signing keys in secret storage Jun 21, 2023
@florianduros florianduros force-pushed the florianduros/element-r/store-cross-signing-key-secret-storage branch from c89db7a to 7fe2d79 Compare June 21, 2023 15:31
@florianduros florianduros force-pushed the florianduros/element-r/store-cross-signing-key-secret-storage branch from 7fe2d79 to 762c7a1 Compare June 21, 2023 15:40
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few tweaks please!

src/rust-crypto/rust-crypto.ts Show resolved Hide resolved
src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Show resolved Hide resolved
spec/integ/crypto/crypto.spec.ts Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/element-r/store-cross-signing-key-secret-storage branch from 1fc8074 to 09a461b Compare June 23, 2023 10:26
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

…g-key-secret-storage

# Conflicts:
#	spec/integ/crypto/crypto.spec.ts
…ss-signing-key-secret-storage' into florianduros/element-r/store-cross-signing-key-secret-storage
@florianduros florianduros added this pull request to the merge queue Jun 23, 2023
Merged via the queue into develop with commit 3c59476 Jun 23, 2023
@florianduros florianduros deleted the florianduros/element-r/store-cross-signing-key-secret-storage branch June 23, 2023 13:25
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Feb 22, 2024
* The Browserify artifact is being deprecated, scheduled for removal in the October 10th release cycle. ([\matrix-org#3189](matrix-org#3189)).
* ElementR: Add `CryptoApi#bootstrapSecretStorage` ([\matrix-org#3483](matrix-org#3483)). Contributed by @florianduros.
* Deprecate `MatrixClient.findVerificationRequestDMInProgress`, `MatrixClient.getVerificationRequestsToDeviceInProgress`, and `MatrixClient.requestVerification`, in favour of methods in `CryptoApi`. ([\matrix-org#3474](matrix-org#3474)).
* Introduce a new `Crypto.VerificationRequest` interface, and deprecate direct access to the old `VerificationRequest` class. Also deprecate some related classes that were exported from `src/crypto/verification/request/VerificationRequest` ([\matrix-org#3449](matrix-org#3449)).
* OIDC: navigate to authorization endpoint ([\matrix-org#3499](matrix-org#3499)). Contributed by @kerryarchibald.
* Support for interactive device verification in Element-R. ([\matrix-org#3505](matrix-org#3505)).
* Support for interactive device verification in Element-R. ([\matrix-org#3508](matrix-org#3508)).
* Support for interactive device verification in Element-R. ([\matrix-org#3490](matrix-org#3490)). Fixes element-hq/element-web#25316.
* Element-R: Store cross signing keys in secret storage ([\matrix-org#3498](matrix-org#3498)). Contributed by @florianduros.
* OIDC: add dynamic client registration util function ([\matrix-org#3481](matrix-org#3481)). Contributed by @kerryarchibald.
* Add getLastUnthreadedReceiptFor utility to Thread delegating to the underlying Room ([\matrix-org#3493](matrix-org#3493)).
* ElementR: Add `rust-crypto#createRecoveryKeyFromPassphrase` implementation ([\matrix-org#3472](matrix-org#3472)). Contributed by @florianduros.
* Aggregate relations regardless of whether event fits into the timeline ([\matrix-org#3496](matrix-org#3496)). Fixes element-hq/element-web#25596.
* Fix bug where switching media caused media in subsequent calls to fail ([\matrix-org#3489](matrix-org#3489)).
* Fix: remove polls from room state on redaction ([\matrix-org#3475](matrix-org#3475)). Fixes element-hq/element-web#25573. Contributed by @kerryarchibald.
* Fix export type `GeneratedSecretStorageKey` ([\matrix-org#3479](matrix-org#3479)). Contributed by @florianduros.
* Close IDB database before deleting it to prevent spurious unexpected close errors ([\matrix-org#3478](matrix-org#3478)). Fixes element-hq/element-web#25597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants