Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: use oidc-client-ts #3544

Merged
merged 12 commits into from
Jul 9, 2023
Merged

OIDC: use oidc-client-ts #3544

merged 12 commits into from
Jul 9, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jul 6, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25392

  • adds oidc-client-ts library
  • use oidc-client-ts for discovery and authorization url creation
  • deprecate autodiscovery.validateDiscoveryAuthenticationConfig and generateAuthorizationUrl

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Jul 6, 2023
@kerryarchibald kerryarchibald mentioned this pull request Jul 6, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald marked this pull request as ready for review July 7, 2023 03:57
@kerryarchibald kerryarchibald requested review from a team as code owners July 7, 2023 03:57
germain-gg
germain-gg approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kerryarchibald kerryarchibald added this pull request to the merge queue Jul 9, 2023
Merged via the queue into develop with commit b8fa030 Jul 9, 2023
21 checks passed
@kerryarchibald kerryarchibald deleted the kerry/oidc-client-ts-start-auth branch July 9, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @germain-gg