Log query parameters on HTTP requests #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #3485
andybalaam
approved these changes
Jul 12, 2023
|
Btw the Cypress tests are failing for unrelated reasons, so happy to merge when you're ready (ping me). |
MadLittleMods
commented
Jul 12, 2023
| @@ -300,7 +300,7 @@ describe("FetchHttpApi", () => { | |||
| const fetchFn = jest.fn().mockReturnValue(deferred.promise); | |||
There was a problem hiding this comment.
happy to merge when you're ready (ping me).
@andybalaam Feel free to merge whenever 🙂
|
Thank you! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This fell out of the merge queue because of known flake element-hq/element-web#25625. Re-adding. |
|
Thanks for the review @andybalaam 🐰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log query parameters on HTTP requests
Follow-up to #3485
Before:
After:
All query parameters values are sanitized to
xxxbut the existence of the query parameter is helpful to distinguish between requests and a peace of mind sanity check to see that they are on the request. Like initial vs incremental/syncwith?since=xxx. In the future, it would be nice to log more values.Dev notes
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.