Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sender instead of content.creator field on m.room.create events #3675

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Aug 24, 2023

matrix-org/matrix-spec-proposals#2175 removed the content.creator field from m.room.create fields in favor of the sender field. This was released with room version 11.

This PR amends the JS SDK to use the sender field instead of the content.creator field regardless of room version. In line with matrix-org/matrix-spec-proposals#2175 (comment), the content.creator field is not used at all anymore.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Use sender instead of content.creator field on m.room.create events (#3675).

@Johennes Johennes marked this pull request as ready for review August 24, 2023 11:57
@Johennes Johennes requested a review from a team as a code owner August 24, 2023 11:57
@Johennes Johennes requested review from germain-gg and dbkr August 24, 2023 11:57
@Johennes Johennes added this pull request to the merge queue Aug 24, 2023
Merged via the queue into develop with commit 65cbbaa Aug 24, 2023
@Johennes Johennes deleted the johannes/no-more-creator branch August 24, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants