-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce console log spam #3896
Reduce console log spam #3896
Conversation
A couple of different things: * Increase the `MaxListeners` setting on `MatrixClient` and `Thread`, so that we don't get "possible EventEmitter leak" warnings * Disable a couple of warnings/info lines that are just part of regular operation and are logged in large volumes.
src/models/read-receipt.ts
Outdated
// client, or malicious behaviour). | ||
logger.warn(`Ignoring receipt for missing event with id ${receipt.eventId}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only just got added - cc @andybalaam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's also currently making a test fail, but I'll leave fixing that up until we decide what to do.
EW currently produces a firehose of these warnings, so I'm struggling to believe they are useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This usually indicates a bug, unless we got unlucky with a message pointed to by a receipt being deleted.
@florianduros and I have a PR we are hoping to get ready today that fixes 2 bugs that would have caused this message, so please can we tolerate it a little longer until that PR can get merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have removed this bit of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this got added back again in #3904
Apparently this is being worked on
Approving this, and we are continuing to discuss the bad receipt message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/webrtc/
part looks fine to me, that log line has outlived its usefulness
thanks all |
There's an awful lot going on in our console at the moment, making it hard to find important stuff, and contributing to poor performance and poor log retention.
A couple of different things in this PR:
Increase the
MaxListeners
setting onMatrixClient
andThread
, so that we don't get "possible EventEmitter leak" warnings.Disable a couple of warning/info lines that are just part of regular operation and are logged in large volumes.
This change is marked as an internal change (Task), so will not be included in the changelog.