Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI to lint workflows with action-validator #3905

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Nov 22, 2023

This is the equivalent of element-hq/element-web#26621 applied to this repository

This, unfortunately, required renaming the release-action workflow because its name threw off the validator.

For: matrix-org/matrix-react-sdk#11930
For: element-hq/element-web#26641
For: element-hq/element-desktop#1347


This change is marked as an internal change (Task), so will not be included in the changelog.

@Johennes Johennes added the T-Task Tasks for the team like planning label Nov 22, 2023
@Johennes Johennes requested a review from a team as a code owner November 22, 2023 15:10
@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2023

could we safely rename and do you have any suggestions for a better name?

We could but it'd have to be replicated onto the 3 repos calling this workflow

@Johennes
Copy link
Contributor Author

We could but it'd have to be replicated onto the 3 repos calling this workflow

I assume this is safe to do outside of release days? How about renaming it into release-executor.yml? I'm blanking on good names.

@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2023

It should be but beware sod's law

@Johennes Johennes added this pull request to the merge queue Nov 24, 2023
Merged via the queue into develop with commit 0c7342c Nov 24, 2023
24 checks passed
@Johennes Johennes deleted the johannes/action-validator branch November 24, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants