Use XHR onprogress to debounce http._request timeout #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just using a timeout to reject ongoing requests, reset the timeout when progress is observed (at least when requests are done from browsers). This is to fix element-hq/element-web#2737
richvdh
requested changes
Mar 15, 2017
src/http-api.js
Outdated
| @@ -679,6 +686,11 @@ module.exports.MatrixHttpApi.prototype = { | |||
| handlerFn(err, response, body); | |||
| }, | |||
| ); | |||
| req.onprogress = (e) => { | |||
There was a problem hiding this comment.
I think you should comment that this will only work in the browser (where opts.request is browser-request instead of request).
Indeed, I'm not sure about the morality of setting onprogress attributes on the request object. Perhaps this should be protected by if ('onprogress' in req) or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just using a timeout to reject ongoing requests, reset the timeout when progress is observed (at least when requests are done from browsers).
This is to fix element-hq/element-web#2737
Supersedes #390