Add missing (and common-ish) HTTP method verbs to types #4188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods
We notably don't include the following:
CONNECT
- Matrix doesn't use this, and is unlikely to foreseeably use it.TRACE
- Same as aboveWe add the following, though:
OPTIONS
- Valid thing to use under https://spec.matrix.org/v1.10/client-server-api/#web-browser-clientsPATCH
- Plausibly useful while we're here. May be used in the near-ish future.HEAD
- Could be used by MSC4120: AllowHEAD
on/download
matrix-spec-proposals#4120We add them now instead of later to avoid relatively tiny PRs needing to go through heavyweight process. Instead, other layers can just use these verbs if and as needed.
It was briefly considered to use https://github.com/jrylan/http-method-enum instead, though the supply chain vulnerability risk doesn't feel worth it.
Checklist
public
/exported
symbols have accurate TSDoc documentation.