Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing (and common-ish) HTTP method verbs to types #4188

Merged
merged 1 commit into from
May 2, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented May 2, 2024

See https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods

We notably don't include the following:

  • CONNECT - Matrix doesn't use this, and is unlikely to foreseeably use it.
  • TRACE - Same as above

We add the following, though:

We add them now instead of later to avoid relatively tiny PRs needing to go through heavyweight process. Instead, other layers can just use these verbs if and as needed.

It was briefly considered to use https://github.com/jrylan/http-method-enum instead, though the supply chain vulnerability risk doesn't feel worth it.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@turt2live turt2live added the T-Task Tasks for the team like planning label May 2, 2024
@turt2live turt2live marked this pull request as ready for review May 2, 2024 22:34
@turt2live turt2live requested a review from a team as a code owner May 2, 2024 22:34
@turt2live turt2live requested review from dbkr and richvdh May 2, 2024 22:34
@turt2live turt2live added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit ef9490c May 2, 2024
34 checks passed
@turt2live turt2live deleted the travis/sliding-sync-safety branch May 2, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants