Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise MSC4156 #4381

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 2, 2024

MSC4156 has been merged so unstable prefixes are no longer required. To my knowledge, the only homeserver that implemented the unstable feature was Synapse. The unstable prefixes in Synapse are being removed with element-hq/synapse#17650.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 2, 2024
@Johennes Johennes marked this pull request as ready for review September 2, 2024 19:52
@Johennes Johennes requested a review from a team as a code owner September 2, 2024 19:52
src/client.ts Show resolved Hide resolved
@dbkr dbkr added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@Johennes
Copy link
Contributor Author

Johennes commented Sep 4, 2024

Failures from the merge queue seem unrelated to the changes here if I'm not mistaken. 🤔

https://github.com/matrix-org/matrix-js-sdk/actions/runs/10698696654/job/29658667338

@dbkr
Copy link
Member

dbkr commented Sep 4, 2024

Yep, seems like a flake

@dbkr dbkr added this pull request to the merge queue Sep 4, 2024
Merged via the queue into matrix-org:develop with commit 52f3540 Sep 4, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants