Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move crypto/recoverykey.ts to crypto-api/recovery-key.ts #4399

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Move crypto/recoverykey.ts to crypto-api/recovery-key.ts #4399

merged 10 commits into from
Sep 13, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Sep 12, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922

Changes:

  • Move crypto/recoverykey.ts to crypto-api/recovery-key.ts
  • Re-export the new crypto-api/recovery-key into the old crypto/recoverykey.ts to avoid breaking changes
  • Deprecate MatrixClient.isValidRecoveryKey and MatrixClient.keyBackupKeyFromRecoveryKey

@florianduros florianduros added the T-Task Tasks for the team like planning label Sep 12, 2024
@florianduros florianduros changed the title Move crypto/recoverykey.ts to crypto-api/recovery-key.ts Move crypto/recoverykey.ts to crypto-api/recovery-key.ts Sep 12, 2024
richvdh
richvdh reviewed Sep 12, 2024
View reviewed changes
src/crypto/backup.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/move-recoverykey branch from aacc8e1 to 6a59684 Compare September 12, 2024 16:15
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/move-recoverykey branch from 02be024 to b46f5d6 Compare September 12, 2024 16:22
@florianduros florianduros marked this pull request as ready for review September 12, 2024 16:27
@florianduros florianduros requested review from a team as code owners September 12, 2024 16:27
@florianduros florianduros mentioned this pull request Sep 12, 2024
Open
@florianduros florianduros added this pull request to the merge queue Sep 13, 2024
@florianduros florianduros removed this pull request from the merge queue due to a manual request Sep 13, 2024
@florianduros florianduros added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@florianduros florianduros added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@florianduros florianduros added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@florianduros
Copy link
Contributor Author

Hmm so lets investigate...

@florianduros florianduros added this pull request to the merge queue Sep 13, 2024
Merged via the queue into develop with commit 8cf5df7 Sep 13, 2024
26 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/move-recoverykey branch September 13, 2024 13:45
This was referenced Sep 18, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

@dbkr dbkr dbkr approved these changes

@andybalaam andybalaam andybalaam approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florianduros @andybalaam @dbkr @richvdh