Move crypto/key_passphrase.ts to crypto-api/key-passphrase.ts
#4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, back to draft I pushed the wrong button. |
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
9640cfd to
d7f433e
Compare
|
I tried to add documentation but my knowledge around crypto is not enough. Maybe @andybalaam or @richvdh can give me a hand on it? Thanks! |
florianduros
changed the title
rypto/key_passphrase.ts to crypto-api/key-passphrase.tscrypto/key_passphrase.ts to crypto-api/key-passphrase.ts
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
d7f433e to
c542099
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
8876e25 to
e1cc2d3
Compare
andybalaam
approved these changes
Sep 13, 2024
richvdh
requested changes
Sep 13, 2024
There was a problem hiding this comment.
These methods are all about deriving a recovery or backup key from a passphrase; the relevant spec is https://spec.matrix.org/v1.11/client-server-api/#deriving-keys-from-passphrases.
…ey-passphrase # Conflicts: # src/client.ts # src/crypto-api/index.ts # src/crypto/backup.ts # src/crypto/index.ts # src/rust-crypto/rust-crypto.ts
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
553ec16 to
8386415
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
8386415 to
81f91c7
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
81f91c7 to
1d99bc4
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
b8b5a5b to
bf5ccb8
Compare
- Call `deriveRecoveryKeyFromPassphrase` into `RustCrypto.createRecoveryKeyFromPassphrase` instead of using `keyFromPassphrase`
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
from
bf5ccb8 to
8845de9
Compare
richvdh
approved these changes
Sep 17, 2024
src/common-crypto/key-passphrase.ts
Outdated
| * Derive a backup key from a passphrase using the salt and iterations from the auth data. | ||
| * @param authData - The auth data containing the salt and iterations | ||
| * @param passphrase - The passphrase to derive the key from | ||
| * @deprecated |
There was a problem hiding this comment.
Suggested change
| * @deprecated | |
| * | |
| * @deprecated Deriving a backup key from a passphrase is not part of the matrix spec. | |
| * Instead, a random key is generated and stored/shared via 4S. |
florianduros
deleted the
florianduros/rip-out-legacy-crypto/move-key-passphrase
branch
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task element-hq/element-web#26922
Changes:
keyFromAuthDatatocommon-cryptoand deprecates it. It should be deleted but it's still used.deriveKeyintocrypto-apiand renamed intoderiveRecoveryKeyFromPassphraseMatrixClient.keyBackupKeyFromPassword