Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RustBackupManager remaining values after current backup removal #4537

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix RustBackupManager remaining values after current backup removal #4537

merged 1 commit into from
Nov 21, 2024

Conversation

florianduros
Copy link
Contributor

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Closes #4534

@florianduros florianduros force-pushed the florianduros/fix-key-backup-delete branch from b92a168 to 393f4d8 Compare November 20, 2024 14:59
@florianduros florianduros marked this pull request as ready for review November 20, 2024 15:04
@florianduros florianduros requested a review from a team as a code owner November 20, 2024 15:04
@florianduros florianduros mentioned this pull request Nov 21, 2024
Open
richvdh
richvdh approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florianduros florianduros added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 2dd4334 Nov 21, 2024
28 checks passed
@florianduros florianduros deleted the florianduros/fix-key-backup-delete branch November 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
2 participants
@florianduros @richvdh