Handle m.forwarded_room_key events #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These terms were somewhat confusing (and, in the case of megolm, misleading), so replace them with explicit senderCurve25519Key and claimedEd25519Key fields.
Rearrange the way _getInboundGroupSession and _saveInboundGroupSession work, so that we can add more things to the storage without growing the parameter list forever.
I'm going to introduce some separate unit tests, so let's give this a different filename to reduce confusion.
not much here yet, but it's a start at least.
when we receive a m.forwarded_room_key, add it to the crypto store, but remember who forwarded it to us, so we can decide whether to trust them separately.
ylecollen
pushed a commit
to matrix-org/matrix-android-sdk
that referenced
this pull request
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-working of #455.
When we get aan m.forwarded_room_key, fish out the keys and add it to the OlmDevice for decrypting things, but remember who forwarded it to us, so we can decide whether to trust them separately.
There is some preparatory work in a number the earlier commits - it is worth looking at them separately.