Disable event encryption for reactions #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reactions, there is a very little gained by encrypting the entire event, as relation data is already kept in the clear. Event encryption for a reaction effectively only obscures the event type, but the purpose is still obvious from the relation data, so nothing is really gained. It also causes quite a few problems, such as: * triggers notifications via default push rules * prevents server-side bundling for reactions The reaction key / content / emoji value does warrant encrypting, but this will be handled separately by encrypting just this value. See matrix-org/matrix-spec-proposals#1849 (review) Fixes element-hq/element-web#10130
bwindels
approved these changes
Jun 26, 2019
This was referenced Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reactions, there is a very little gained by encrypting the entire event, as
relation data is already kept in the clear. Event encryption for a reaction
effectively only obscures the event type, but the purpose is still obvious from
the relation data, so nothing is really gained. It also causes quite a few
problems, such as:
The reaction key / content / emoji value does warrant encrypting, but this will
be handled separately by encrypting just this value.
See matrix-org/matrix-spec-proposals#1849 (review)
Fixes element-hq/element-web#10130