Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matrix-web-i18n dependency and fix TranslationStringsObject type #20

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Add matrix-web-i18n dependency and fix TranslationStringsObject type #20

merged 3 commits into from
Sep 29, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 29, 2023

No description provided.

@t3chguy t3chguy requested a review from a team as a code owner September 29, 2023 13:30
@t3chguy t3chguy mentioned this pull request Sep 29, 2023
Merged
@t3chguy t3chguy self-assigned this Sep 29, 2023
@t3chguy t3chguy enabled auto-merge (squash) September 29, 2023 13:58
florianduros
florianduros approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is matrix-web-i18n doing ?

@t3chguy t3chguy merged commit 29d8e41 into main Sep 29, 2023
6 checks passed
@t3chguy t3chguy deleted the t3chguy/localazy-custom-translations branch September 29, 2023 15:43
@t3chguy
Copy link
Member Author

t3chguy commented Sep 29, 2023

@florianduros providing types - see https://github.com/matrix-org/matrix-react-sdk-module-api/pull/20/files#diff-7c41c69ed39c3ca36c425fec906d1949a172f13f1ecbe85af0d041f366b6e9bf

@Johennes Johennes mentioned this pull request Oct 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @florianduros