Update existing 3PID management UX

This tweaks the appearance of the existing 3PID management UX to use a different style for the remove button. This styling will more closely match the soon to be added 3PID discovery settings. Part of element-hq/element-web#10159
matrix-org · Aug 5, 2019 · 11f2b43 · 11f2b43
1 parent ab05d8c
commit 11f2b43
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 14 deletions.
diff --git a/res/css/views/settings/_EmailAddresses.scss b/res/css/views/settings/_EmailAddresses.scss
@@ -15,6 +15,8 @@ limitations under the License.
 */
 
 .mx_ExistingEmailAddress {
+    display: flex;
+    align-items: center;
     margin-bottom: 5px;
 }
 
@@ -24,14 +26,12 @@ limitations under the License.
     vertical-align: middle;
 }
 
-.mx_ExistingEmailAddress_email {
-    vertical-align: middle;
-}
-
+.mx_ExistingEmailAddress_email,
 .mx_ExistingEmailAddress_promptText {
+    flex: 1;
     margin-right: 10px;
 }
 
 .mx_ExistingEmailAddress_confirmBtn {
-    margin-right: 5px;
+    margin-left: 5px;
 }
diff --git a/res/css/views/settings/_PhoneNumbers.scss b/res/css/views/settings/_PhoneNumbers.scss
@@ -15,6 +15,8 @@ limitations under the License.
 */
 
 .mx_ExistingPhoneNumber {
+    display: flex;
+    align-items: center;
     margin-bottom: 5px;
 }
 
@@ -24,16 +26,14 @@ limitations under the License.
     vertical-align: middle;
 }
 
-.mx_ExistingPhoneNumber_address {
-    vertical-align: middle;
-}
-
+.mx_ExistingPhoneNumber_address,
 .mx_ExistingPhoneNumber_promptText {
+    flex: 1;
     margin-right: 10px;
 }
 
 .mx_ExistingPhoneNumber_confirmBtn {
-    margin-right: 5px;
+    margin-left: 5px;
 }
 
 .mx_PhoneNumbers_input {

diff --git a/src/components/views/settings/EmailAddresses.js b/src/components/views/settings/EmailAddresses.js
@@ -102,9 +102,10 @@ export class ExistingEmailAddress extends React.Component {
 
         return (
             <div className="mx_ExistingEmailAddress">
-                <img src={require("../../../../res/img/feather-customised/cancel.svg")} width={14} height={14}
-                     onClick={this._onRemove} className="mx_ExistingEmailAddress_delete" alt={_t("Remove")} />
                 <span className="mx_ExistingEmailAddress_email">{this.props.email.address}</span>
+                <AccessibleButton onClick={this._onRemove} kind="danger_sm">
+                    {_t("Remove")}
+                </AccessibleButton>
             </div>
         );
     }

diff --git a/src/components/views/settings/PhoneNumbers.js b/src/components/views/settings/PhoneNumbers.js
@@ -97,9 +97,10 @@ export class ExistingPhoneNumber extends React.Component {
 
         return (
             <div className="mx_ExistingPhoneNumber">
-                <img src={require("../../../../res/img/feather-customised/cancel.svg")} width={14} height={14}
-                     onClick={this._onRemove} className="mx_ExistingPhoneNumber_delete" alt={_t("Remove")} />
                 <span className="mx_ExistingPhoneNumber_address">+{this.props.msisdn.address}</span>
+                <AccessibleButton onClick={this._onRemove} kind="danger_sm">
+                    {_t("Remove")}
+                </AccessibleButton>
             </div>
         );
     }