rename noPopout to: noPopoutButton (more explicit)

matrix-org · Oct 25, 2021 · 14b191d · 14b191d
1 parent 7243e34
commit 14b191d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/components/views/dialogs/WidgetCapabilitiesPromptDialog.tsx b/src/components/views/dialogs/WidgetCapabilitiesPromptDialog.tsx
@@ -106,7 +106,6 @@ export default class WidgetCapabilitiesPromptDialog extends React.PureComponent<
 
             return 0;
         });
-        // const filteredCapabilites = //TODO this would be where the NoPopout capability text can be hidden and approved by default
         const checkboxRows = orderedCapabilities.map(([cap, isChecked], i) => {
             const text = CapabilityText.for(cap, this.props.widgetKind);
             const byline = text.byline

diff --git a/src/components/views/elements/AppTile.tsx b/src/components/views/elements/AppTile.tsx
@@ -84,7 +84,7 @@ interface IState {
     error: Error;
     menuDisplayed: boolean;
     widgetPageTitle: string;
-    noPopout: boolean;
+    noPopoutButton: boolean;
 }
 
 import { logger } from "matrix-js-sdk/src/logger";
@@ -156,7 +156,7 @@ export default class AppTile extends React.Component<IProps, IState> {
             error: null,
             menuDisplayed: false,
             widgetPageTitle: this.props.widgetPageTitle,
-            noPopout: true,
+            noPopoutButton: true,
         };
     }
 
@@ -298,7 +298,7 @@ export default class AppTile extends React.Component<IProps, IState> {
             this.sgWidget.widgetApi.transport.send(ElementWidgetActions.ClientReady, {});
         }
         this.setState({
-            noPopout: this.sgWidget.widgetApi.hasCapability(MatrixCapabilities.RequiresClient)
+            noPopoutButton: this.sgWidget.widgetApi.hasCapability(MatrixCapabilities.RequiresClient)
         });
     };
 
@@ -517,7 +517,7 @@ export default class AppTile extends React.Component<IProps, IState> {
                             { this.props.showTitle && this.getTileTitle() }
                         </span>
                         <span className="mx_AppTileMenuBarWidgets">
-                            {(this.props.showPopout && !this.state.noPopout) && <AccessibleButton
+                            {(this.props.showPopout && !this.state.noPopoutButton) && <AccessibleButton
                                 className="mx_AppTileMenuBar_iconButton mx_AppTileMenuBar_iconButton_popout"
                                 title={_t('Popout widget')}
                                 onClick={this.onPopoutWidgetClick}