Fix vertical spacing in compact context menus

Fix element-hq/element-web#20801 Regressed in #7339 Relevant styles were first added in #4858 (context behind why the original styles were added)
matrix-org · Feb 1, 2022 · 4dc9ef9 · 4dc9ef9
1 parent 9ffc141
commit 4dc9ef9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/res/css/views/context_menus/_IconizedContextMenu.scss b/res/css/views/context_menus/_IconizedContextMenu.scss
@@ -50,21 +50,21 @@ limitations under the License.
         }
 
         // round the top corners of the top button for the hover effect to be bounded
-        &:first-child .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind):first-child {
+        &:first-child .mx_IconizedContextMenu_item:first-child {
             border-radius: 8px 8px 0 0; // radius matches .mx_ContextualMenu
         }
 
         // round the bottom corners of the bottom button for the hover effect to be bounded
-        &:last-child .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind):last-child {
+        &:last-child .mx_IconizedContextMenu_item:last-child {
             border-radius: 0 0 8px 8px; // radius matches .mx_ContextualMenu
         }
 
         // round all corners of the only button for the hover effect to be bounded
-        &:first-child:last-child .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind):first-child:last-child {
+        &:first-child:last-child .mx_IconizedContextMenu_item:first-child:last-child {
             border-radius: 8px; // radius matches .mx_ContextualMenu
         }
 
-        .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind) {
+        .mx_IconizedContextMenu_item {
             // pad the inside of the button so that the hover background is padded too
             padding-top: 12px;
             padding-bottom: 12px;
@@ -130,7 +130,7 @@ limitations under the License.
     }
 
     .mx_IconizedContextMenu_optionList_red {
-        .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind) {
+        .mx_IconizedContextMenu_item {
             color: $alert !important;
         }
 
@@ -148,7 +148,7 @@ limitations under the License.
     }
 
     .mx_IconizedContextMenu_active {
-        &.mx_AccessibleButton:not(.mx_AccessibleButton_hasKind), .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind) {
+        &.mx_IconizedContextMenu_item, .mx_IconizedContextMenu_item {
             color: $accent !important;
         }
 

diff --git a/res/css/views/messages/_JumpToDatePicker.scss b/res/css/views/messages/_JumpToDatePicker.scss
@@ -16,6 +16,8 @@ limitations under the License.
 
 .mx_JumpToDatePicker_form {
     display: flex;
+    padding-top: 12px;
+    padding-bottom: 12px;
 }
 
 .mx_JumpToDatePicker_label {

diff --git a/src/components/views/context_menus/IconizedContextMenu.tsx b/src/components/views/context_menus/IconizedContextMenu.tsx
@@ -59,6 +59,7 @@ export const IconizedContextMenuRadio: React.FC<IRadioProps> = ({
     return <MenuItemRadio
         {...props}
         className={classNames(className, {
+            "mx_IconizedContextMenu_item": true,
             mx_IconizedContextMenu_active: active,
         })}
         active={active}
@@ -93,6 +94,7 @@ export const IconizedContextMenuCheckbox: React.FC<ICheckboxProps> = ({
     return <MenuItemCheckbox
         {...props}
         className={classNames(className, {
+            "mx_IconizedContextMenu_item": true,
             mx_IconizedContextMenu_active: active,
         })}
         active={active}
@@ -105,7 +107,7 @@ export const IconizedContextMenuCheckbox: React.FC<ICheckboxProps> = ({
 };
 
 export const IconizedContextMenuOption: React.FC<IOptionProps> = ({ label, iconClassName, children, ...props }) => {
-    return <MenuItem {...props} label={label}>
+    return <MenuItem {...props} className="mx_IconizedContextMenu_item" label={label}>
         { iconClassName && <span className={classNames("mx_IconizedContextMenu_icon", iconClassName)} /> }
         <span className="mx_IconizedContextMenu_label">{ label }</span>
         { children }

diff --git a/src/components/views/messages/DateSeparator.tsx b/src/components/views/messages/DateSeparator.tsx
@@ -193,7 +193,6 @@ export default class DateSeparator extends React.Component<IProps, IState> {
         if (this.state.contextMenuPosition) {
             contextMenu = <IconizedContextMenu
                 {...contextMenuBelow(this.state.contextMenuPosition)}
-                compact
                 onFinished={this.onContextMenuCloseClick}
             >
                 <IconizedContextMenuOptionList first>