Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove ineffective white space characters from VerifyEmailModal.tsx #10141

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Remove ineffective white space characters from VerifyEmailModal.tsx #10141

merged 1 commit into from
Feb 13, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 11, 2023

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Those white space characters introduced with #9581 are applied to Weblate, which should make translators confused about their meaning, as if they were used to design the UI while they are not. Multiple white space characters and \n are ignored on web pages.

After (not changed)

after

type: task

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Feb 11, 2023
@luixxiul luixxiul changed the title Remove ineffective white space characters from VerifyEmailModa.tsx Remove ineffective white space characters from VerifyEmailModal.tsx Feb 11, 2023
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review February 11, 2023 09:43
@luixxiul luixxiul requested a review from a team as a code owner February 11, 2023 09:43
@luixxiul luixxiul requested review from dbkr and justjanne February 11, 2023 09:43
@justjanne justjanne merged commit 986b7cb into matrix-org:develop Feb 13, 2023
@luixxiul luixxiul deleted the localization-4 branch February 13, 2023 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants