-
-
Notifications
You must be signed in to change notification settings - Fork 828
use spacing variables in components->views #10564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced this is a useful change. Do we need to go through and replace every single margin
, padding
and position with a $spacing
variable? What does that project actually achieve?
@gsouquet what are your thoughts?
@@ -67,7 +67,7 @@ limitations under the License. | |||
} | |||
|
|||
.mx_BeaconStatus_label { | |||
margin-bottom: 2px; | |||
margin-bottom: $spacing-2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the whole point of the $spacing variables was to encourage people not to use values which are not a multiple of 4?
If needed, it would be appreciated to update this line on the style guide to make an internal agreement public. |
@NSV1991: thank you for the contribution, but as per element-hq/element-web#25070: we don't think this is particularly useful. |
fixes element-hq/element-web#25070
Type: enhancement
Signed-off-by: Neeraj Vageele neerajvageele451@gmail.com
Checklist
Here's what your changelog entry will look like:
✨ Features
_spacing.pcss
element-hq/element-web#25070. Contributed by @NSV1991.