Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update file-panel.spec.ts - use Cypress Testing Library #10574

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Update file-panel.spec.ts - use Cypress Testing Library #10574

merged 1 commit into from
Apr 17, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 12, 2023

For element-hq/element-web#25033

This PR intends to apply Cypress Testing Library to file-panel.spec.ts.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 12, 2023
@luixxiul luixxiul marked this pull request as ready for review April 12, 2023 10:58
@luixxiul luixxiul requested a review from a team as a code owner April 12, 2023 10:58
@luixxiul
Copy link
Contributor Author

@t3chguy Was this forgotten to be added to the queue?

@t3chguy t3chguy added this pull request to the merge queue Apr 17, 2023
@t3chguy
Copy link
Member

t3chguy commented Apr 17, 2023

Seems that way, thanks for the ping @luixxiul

Merged via the queue into matrix-org:develop with commit 9c277d6 Apr 17, 2023
@luixxiul luixxiul deleted the test-file-panel branch April 17, 2023 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants