This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Deprecate the $spacing- variables
#10686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
|
Will this deprecate this PR? #10552 |
germain-gg
approved these changes
Apr 21, 2023
Comment on lines
+22
to
+25
| * In future, we plan to introduce variables named according to their purpose rather than their size. Additionally, | ||
| * we want switch to custom CSS properties (https://github.com/vector-im/element-web/issues/21656), so we might have | ||
| * `--spacing-standard` or something. For now, you might as well use hardcoded px values for lengths (except for font | ||
| * sizes, for which see the `$font-<N>px` variables). |
There was a problem hiding this comment.
Yes, this will be done as part of what https://github.com/vector-im/compound-design-tokens outputs.
I've commented on the linked issue to explain a rough path to a better future
Given element-hq/element-web#21656 (comment), I think it probably does, yes. |
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Apr 21, 2023
Per matrix-org/matrix-react-sdk#10686, these don't make much sense at the moment.
3 tasks
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Apr 21, 2023
Per matrix-org/matrix-react-sdk#10686, these don't make much sense at the moment.
3 tasks
germain-gg
pushed a commit
that referenced
this pull request
Jun 6, 2023
The variables on _spacing.pcss have been deprecated by #10686
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and write some comments about the
$font-variables.I think this is an accurate representation of what we discussed in our meeting yesterday, but would appreciate feedback.
If we're agreed on this I will follow up with an update to the
code_styledoc in element-web.This change is marked as an internal change (Task), so will not be included in the changelog.