Conform more of the codebase to strictNullChecks
#10738
Conversation
t3chguy
added
the
T-Task
| permalinkCreator={this.props.permalinkCreator} | ||
| /> | ||
| ); | ||
| if (roomId) { |
There was a problem hiding this comment.
| if (roomId) { | |
| if (!!roomId && !!this.props.permalinkCreator) { |
(to fix implicit boolean cast, and type failure on permalinkCreator)
There was a problem hiding this comment.
I specifically didn't touch permalinkCreator as there are multiple related type fails around the code and it may be intentional that it can be passed as undefined
| @@ -1087,7 +1087,7 @@ export class RoomView extends React.Component<IRoomProps, IRoomState> { | |||
| case "picture_snapshot": | |||
| ContentMessages.sharedInstance().sendContentListToRoom( | |||
| [payload.file], | |||
| this.state.room.roomId, | |||
| this.getRoomId(), | |||
There was a problem hiding this comment.
this is still failing. Likewise various similar references below.
There was a problem hiding this comment.
This was intentional, consolidates everything to use this single method which in future will be made non-optional and to throw an error if no roomId so it is picked up by the error boundary
There was a problem hiding this comment.
This was deferred to a later task, this just consolidates the handling
Requires matrix-org/matrix-react-sdk-module-api#15Requires matrix-org/matrix-js-sdk#3330Fixes element-hq/element-web#24752
This change is marked as an internal change (Task), so will not be included in the changelog.