Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove some obsolete CSS rules #10754

Merged
merged 8 commits into from
May 3, 2023
Merged

Remove some obsolete CSS rules #10754

merged 8 commits into from
May 3, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 1, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25238

This PR intends to remove some of the obsolete CSS rules which should have been removed.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

luixxiul added 3 commits May 1, 2023 06:37
@luixxiul
Remove mx_MImageReplyBody_info from _MImageReplyBody.pcss
c11305a 
Edited by 866a11d
Deprecated by 6b3098d

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Remove mx_WidgetCard_maxPinnedTooltip from _WidgetCard.pcss
13a3f83 
Added by ef0843d
Deprecated by ada6d1a

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Remove mx_AliasSettings_editable from _AliasSettings.pcss
5a73086 
Added by eac50aa
Deprecated by 2903a0e

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 1, 2023
@luixxiul
Remove mx_AliasSettings_localAliasHeader from _AliasSettings.pcss
19a84ff 
Added by 3253d0b
Deprecated by 2e3f225

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 1, 2023
luixxiul added 2 commits May 1, 2023 06:58
@luixxiul
Remove mx_RoomList_explorePrompt from _RoomList.pcss
590bb6b 
Added by e20b375
Deprecated by 328d7ea

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Remove mx_Stickers_hideStickers from _Stickers.pcss
5bcb141 
Added by 79d3cca
Deprecated by 31b3b2e

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review May 1, 2023 06:58
@luixxiul luixxiul requested a review from a team as a code owner May 1, 2023 06:58
@luixxiul luixxiul requested review from richvdh and kerryarchibald May 1, 2023 06:58
@luixxiul
Copy link
Contributor Author

luixxiul commented May 1, 2023

Jest error is due to element-hq/element-web#25230

@luixxiul luixxiul mentioned this pull request May 1, 2023
Closed
@kerryarchibald kerryarchibald enabled auto-merge May 1, 2023 20:11
auto-merge was automatically disabled May 3, 2023 02:59

Head branch was pushed to by a user without write access

@luixxiul luixxiul requested a review from kerryarchibald May 3, 2023 02:59
@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2023

Fixed the conflict.

@richvdh richvdh enabled auto-merge May 3, 2023 12:18
@richvdh richvdh added this pull request to the merge queue May 3, 2023
Merged via the queue into matrix-org:develop with commit f5d7989 May 3, 2023
@luixxiul luixxiul deleted the archaeology branch May 3, 2023 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luixxiul @richvdh @kerryarchibald