Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use semantic heading in user settings Sidebar & Voip #10782

Merged
merged 35 commits into from
May 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
036e1f9
split SettingsSection out of SettingsTab, replace usage
Apr 28, 2023
8e4f061
correct copyright
Apr 28, 2023
77f046e
use semantic headings in GeneralRoomSettingsTab
Apr 28, 2023
2b251b4
use SettingsTab and SettingsSubsection in room settings
Apr 28, 2023
7d94b71
fix VoipRoomSettingsTab
Apr 28, 2023
d011479
Merge branch 'kerry/24922/settings-section-component' into kerry/2492…
Apr 28, 2023
0bf54f3
Merge branch 'develop' into kerry/24922/room-settings-headings
Apr 30, 2023
7354c05
use SettingsSection components in space settings
May 1, 2023
0d0aed5
settingssubsection text component
May 1, 2023
8086361
use semantic headings in HelpUserSetttings tab
May 1, 2023
f7cc24f
use ExternalLink components for external links
May 2, 2023
8e74b74
test
May 2, 2023
4519726
strict
May 2, 2023
74789d9
Merge branch 'develop' into kerry/24932/use-external-link
May 2, 2023
7eca36f
Merge branch 'develop' into kerry/24932/use-external-link
May 3, 2023
9dbe2ce
Merge branch 'kerry/24932/use-external-link' into kerry/24922/user-se…
May 3, 2023
5ff3266
lint
May 3, 2023
fb1ace5
semantic heading in labs settings
May 3, 2023
ea5edeb
semantic headings in keyboard settings tab
May 3, 2023
3a28816
semantic heading in preferencesusersettingstab
May 3, 2023
50d7629
tidying
May 3, 2023
d466887
use new settings components in eventindexpanel
May 3, 2023
953b6db
Merge branch 'develop' into kerry/24922/user-settings-headings-1
May 3, 2023
de109c6
Merge branch 'kerry/24922/user-settings-headings-1' into kerry/24922/…
May 3, 2023
e1d7ab5
Merge branch 'develop' into kerry/24922/user-settings-headings-labs
May 4, 2023
5cf9071
findByTestId
May 4, 2023
6d2d8ca
prettier
May 4, 2023
ff66c05
Merge branch 'kerry/24922/user-settings-headings-labs' into kerry/249…
May 4, 2023
3a78757
semantic headings and style refresh for crypto settings
May 4, 2023
da0cf93
Merge branch 'kerry/24922/user-settings-headings-security' of https:/…
May 4, 2023
7b04972
e2e panel
May 4, 2023
bb27709
semantic headings and cleanup in Sidebar user settings
May 4, 2023
e8544fb
semantic heading in voice user settings
May 4, 2023
1484cb2
sonarcloud bug and test
May 4, 2023
3da02e5
Merge branch 'develop' into kerry/24922/user-settings-heading-voip-si…
May 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion res/css/_components.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@
@import "./views/settings/tabs/user/_MjolnirUserSettingsTab.pcss";
@import "./views/settings/tabs/user/_SecurityUserSettingsTab.pcss";
@import "./views/settings/tabs/user/_SidebarUserSettingsTab.pcss";
@import "./views/settings/tabs/user/_VoiceUserSettingsTab.pcss";
@import "./views/spaces/_SpaceBasicSettings.pcss";
@import "./views/spaces/_SpaceChildrenPicker.pcss";
@import "./views/spaces/_SpaceCreateMenu.pcss";
Expand Down
2 changes: 2 additions & 0 deletions res/css/structures/_QuickSettingsButton.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,11 @@ limitations under the License.
}

.mx_QuickSettingsButton_icon {
// TODO remove when all icons have fill=currentColor
* {
fill: $secondary-content;
}
color: $secondary-content;
width: 16px;
height: 16px;
position: absolute;
Expand Down
72 changes: 15 additions & 57 deletions res/css/views/settings/tabs/user/_SidebarUserSettingsTab.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -14,67 +14,25 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

.mx_SidebarUserSettingsTab {
.mx_Checkbox {
margin-top: 12px;
font-size: $font-15px;
line-height: $font-24px;
color: $secondary-content;
}

.mx_SidebarUserSettingsTab_checkboxMicrocopy {
margin-bottom: 12px;
margin-left: 24px;
font-size: $font-15px;
line-height: $font-24px;
color: $secondary-content;
}

.mx_SidebarUserSettingsTab_homeAllRoomsCheckbox {
margin-left: 24px;

& + div {
margin-left: 48px;
}
}
.mx_SidebarUserSettingsTab_homeAllRoomsCheckbox {
margin-left: 24px;

.mx_SidebarUserSettingsTab_homeCheckbox,
.mx_SidebarUserSettingsTab_favouritesCheckbox,
.mx_SidebarUserSettingsTab_peopleCheckbox,
.mx_SidebarUserSettingsTab_orphansCheckbox {
.mx_Checkbox_background + div {
padding-left: 20px;
position: relative;

&::before {
background-color: $secondary-content;
content: "";
mask-repeat: no-repeat;
mask-position: center;
mask-size: contain;
width: 16px;
height: 16px;
position: absolute;
left: 0;
top: 50%;
transform: translateY(-50%);
}
}
}

.mx_SidebarUserSettingsTab_homeCheckbox .mx_Checkbox_background + div::before {
mask-image: url("$(res)/img/element-icons/home.svg");
}

.mx_SidebarUserSettingsTab_favouritesCheckbox .mx_Checkbox_background + div::before {
mask-image: url("$(res)/img/element-icons/roomlist/favorite.svg");
& + div {
margin-left: 48px;
}
}

.mx_SidebarUserSettingsTab_peopleCheckbox .mx_Checkbox_background + div::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
.mx_SidebarUserSettingsTab_checkbox {
margin-bottom: $spacing-8;
// override checkbox styles˚
label {
align-items: flex-start !important;
}

.mx_SidebarUserSettingsTab_orphansCheckbox .mx_Checkbox_background + div::before {
mask-image: url("$(res)/img/element-icons/roomlist/hash-circle.svg");
svg {
height: 16px;
width: 16px;
margin-right: $spacing-8;
margin-bottom: -1px;
}
}
23 changes: 0 additions & 23 deletions res/css/views/settings/tabs/user/_VoiceUserSettingsTab.pcss

This file was deleted.

2 changes: 1 addition & 1 deletion res/img/element-icons/home.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions res/img/element-icons/room/members.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion res/img/element-icons/roomlist/favorite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading