Fix regression in emoji picker order mangling after clearing filter

src/components/views/emojipicker/EmojiPicker.tsx

@@ -269,7 +269,7 @@ class EmojiPicker extends React.Component<IProps, IState> {
                 emojis = cat.id === "recent" ? this.recentlyUsed : DATA_BY_CATEGORY[cat.id];
             }
 
-            if (lcFilter) {
+            if (!!lcFilter) {
                 emojis = emojis.filter((emoji) => this.emojiMatchesFilter(emoji, lcFilter));
                 // Copy the array to not clobber the original unfiltered sorting
                 emojis = [...emojis].sort((a, b) => {

test/components/views/emojipicker/EmojiPicker-test.tsx

@@ -30,10 +30,15 @@ describe("EmojiPicker", function () {
             <EmojiPicker ref={ref} onChoose={(str: string) => false} onFinished={jest.fn()} />,
         );
 
+        // Record the HTML before filtering
         const beforeHtml = container.innerHTML;
+
+        // Apply a filter and assert that the HTML has changed
         //@ts-ignore private access
         ref.current!.onChangeFilter("test");
         expect(beforeHtml).not.toEqual(container.innerHTML);
+
+        // Clear the filter and assert that the HTML matches what it was before filtering
         //@ts-ignore private access
         ref.current!.onChangeFilter("");
         expect(beforeHtml).toEqual(container.innerHTML);