Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix: flaky percy test "Rendering permalinks" #10874

Merged
merged 15 commits into from
May 19, 2023
Merged

Fix: flaky percy test "Rendering permalinks" #10874

merged 15 commits into from
May 19, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 12, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#25283

Try hiding elements instead of removing them to stabilise scroll position.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 12, 2023
@kerryarchibald kerryarchibald changed the title hide elements instead of removing them which might effect scroll Fix: flaky percy test "Rending permalinks" May 12, 2023
@kerryarchibald kerryarchibald changed the title Fix: flaky percy test "Rending permalinks" Fix: flaky percy test "Rendering permalinks" May 12, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review May 12, 2023 02:45
@kerryarchibald kerryarchibald requested a review from a team as a code owner May 12, 2023 02:46
@andybalaam
Copy link
Contributor

Wow, thank you for working on this! Please undo my disablement from #10878 if you are happy that this fixes the flake.

@kerryarchibald kerryarchibald added this pull request to the merge queue May 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 18, 2023
@kerryarchibald kerryarchibald added X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue and removed X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue labels May 18, 2023
@kerryarchibald kerryarchibald removed the X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue label May 19, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue May 19, 2023
Merged via the queue into develop with commit 8513d2f May 19, 2023
@kerryarchibald kerryarchibald deleted the kerry/25283/flaky-percy-permalinks branch May 19, 2023 03:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky Percy test "Permalink rendering"
3 participants
@kerryarchibald @andybalaam @germain-gg