This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove a duplicate external link icon from AnalyticsLearnMoreDialog
#10924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
X-Release-Blocker
luixxiul
commented
May 16, 2023
Comment on lines
41
to
48
| cy.intercept("/config.json?cachebuster=*", (req) => { | ||
| req.continue((res) => { | ||
| res.send(200, { | ||
| ...res.body, | ||
| posthog: { | ||
| project_api_key: "foo", | ||
| api_host: "bar", | ||
| }, |
There was a problem hiding this comment.
Based on:
matrix-react-sdk/cypress/e2e/toasts/analytics-toast.spec.ts
Lines 69 to 76 in 6a3f59c
github-actions
bot
added
Z-Community-PR
|
The E2E test fails due to another toast overlapping the toast for the analytics. It needs checking, so I removed the test for now, not to block the release. |
t3chguy
approved these changes
May 16, 2023
3 tasks
RiotRobot
pushed a commit
that referenced
this pull request
May 16, 2023
(cherry picked from commit 4cc6ab1)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to remove a duplicate external link icon from
AnalyticsLearnMoreDialog.It also suggests to add a E2E test with a Percy snapshot test.The issue is essentially the same one as element-hq/element-web#25384 (37b7dfe#diff-5c6639bce05427539d7491614ced8865c159ce506a05bae549ee545716fe6b88R59-R62).
type: defect
Notes: none
element-web notes: none
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change has no change notes, so will not be included in the changelog.