Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[Backport staging] Use semantic headings in user settings - integrations and account deletion #10931

Merged
merged 1 commit into from
May 17, 2023

Conversation

RiotRobot
Copy link
Contributor

@RiotRobot RiotRobot commented May 17, 2023

Backport 8cd84b0 from #10837.


Here's what your changelog entry will look like:

✨ Features

  • [Backport staging] Use semantic headings in user settings - integrations and account deletion (#10931). Contributed by @RiotRobot.

…etion (#10837)

* allow testids in settings sections

* use semantic headings in LabsUserSettingsTab

* put back margin var

* use SettingsTab wrapper

* use semantic headings for deactivate acc section

* use semantic heading in manage integratios

* i18n

* explicit cast to boolean

* Update src/components/views/settings/shared/SettingsSubsection.tsx

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* test manage integration settings

* test deactivate account section display

* remove debug

* fix cypress test

---------

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
(cherry picked from commit 8cd84b0)
@RiotRobot RiotRobot requested a review from a team as a code owner May 17, 2023 09:04
@RiotRobot RiotRobot requested review from richvdh and weeman1337 and removed request for a team May 17, 2023 09:04
@RiotRobot RiotRobot added X-Release-Blocker This affects the current release cycle and must be solved for a release to happen T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels May 17, 2023
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 17, 2023
@t3chguy t3chguy merged commit ddcbb1a into staging May 17, 2023
@t3chguy t3chguy deleted the backport-10837-to-staging branch May 17, 2023 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Release-Blocker This affects the current release cycle and must be solved for a release to happen Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants