This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Settings panels: avoid exceptions with rust crypto #10962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are using rust crypto, `client.crypto` is undefined. We'll need to fix these up better in future, but for now, just return early.
richvdh
added
the
T-Task
germain-gg
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are using rust crypto,
client.cryptois undefined. We'll need to fix these up better in future (element-hq/element-web#24828 and element-hq/element-web#25318), but for now, just return early to suppress the uncaught exception which is making my cypress tests sad.This change is marked as an internal change (Task), so will not be included in the changelog.