Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Slightly less bad message notification sound #11078

Closed
wants to merge 1 commit into from

Conversation

piegamesde
Copy link

@piegamesde piegamesde commented Jun 12, 2023

Due to popular request

Closes element-hq/element-web#5031, related to element-hq/element-web#5891

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@piegamesde piegamesde requested a review from a team as a code owner June 12, 2023 22:23
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jun 12, 2023
Signed-off-by: piegames <git@piegames.de>
@piegamesde piegamesde force-pushed the notification-sound branch from 78f3d65 to 8343048 Compare June 12, 2023 22:28
@t3chguy t3chguy requested a review from a team June 14, 2023 07:49
@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jun 23, 2023
@harmathy
Copy link
Contributor

harmathy commented Jul 5, 2023

No offence, but for me the current sound is much less annoying than this sound. In my opinion, solving element-hq/element-web#5891 is the only solution.

@lectrode
Copy link

lectrode commented Jul 5, 2023

Unfortunately, as-is, this does not resolve #5031. This changes the notification sound to something less jarring (opinions of those with a different taste not withstanding), but does not address the ringtone, which is arguably the bigger concern of the two (i.e. the sound that is played upon receiving a call).

@piegamesde
Copy link
Author

piegamesde commented Jul 5, 2023

@harmathy I stand by my point made in element-hq/element-web#5891 (comment) – most other messengers don't have customizable notification sounds, and nobody is complaining. Customization here is a bonus, but providing a sane default is a necessary requirement.

My goal of this pull request is to show that making something less bad than the status quo takes at most two hours, and somebody actually skilled could come up with something actually good in an evening or so. So feel free to one-up me.

If you could go into detail what you find annoying about my proposed sound that would be appreciated, I might be able to improve it.


@lectrode You are right that technically element-hq/element-web#5031 is only about the ringtone, while this is only about the notification sound. I'll update the wording to "partially fixed" accordingly in my PR description. I've unfortunately lost track of all the issues and closed duplicates across several repositories on this topic, if you know a better issue to mention here let me know (Edit found it: element-hq/element-web#20198). IMO though, the title of element-hq/element-web#5031 should be expanded to also include notification sounds, like in element-hq/element-web#5891.

I did only the notification sound because I don't use element calls so I never hear the ringing sound. Also, I had only the stuff lying around for making a notification sound. So, one improvement at a time I guess.

@harmathy
Copy link
Contributor

If you could go into detail what you find annoying about my proposed sound that would be appreciated, I might be able to improve it.

I'm not an expert. I guess the increasing tone is in slightly reminiscent of a siren. Notification sounds, I usually use, have only a single tone pitch.

@langleyd
Copy link
Contributor

Thanks for taking the time to contribute @piegamesde but changing the notification sound is something that would require broader research from our design team. Unfortunately I don’t have a timescale to share on when that research might happen.

@langleyd langleyd closed this Mar 26, 2024
@piegamesde
Copy link
Author

Oh, fortunately, I can share a timescale on when that research will happen: not within the last six years, and not within the next six years.

I made this pull request to prove a point: It really does not take lots of work to come up with something less bad than the status quo. No need for fancy "research", no need for perfect to be the enemy of the good.

At this point, the Element notification sound has become a meme. I'm not sure if you are aware to which extent the sounds are a poster child of the bad Element UX. This is not a resources issue, but a prioritization issue, and I urge you to reconsider your priorities on this.

@lectrode
Copy link

lectrode commented Mar 27, 2024

that would require broader research from our design team

Please consider shifting the burden from being solely on the "design team" to something a bit more shared. They do not need to work in a dark room on a black box and only release something if they've determined it to be absolutely perfect.

Instead, maybe have them put together a handful of feasible (royalty free/creative commons/otherwise unencumbered) options (maybe 4 or 5) in a poll and let the user base vote on what to make default. Then do that again for the ring tone.

They might not even need to do that much - maybe you can do what a number of desktop environments do for their default wallpapers and make it a contest: have your user base submit their creations and let those be voted on.

The design team can still work on their grand plan of sound themes or whatever down the line. Sane default sounds for now would be a substantial step forward toward increased usability and wider adoption.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ringtone and Notification sounds are jarring/stressful
5 participants