Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix bug in inviting users to a room #11082

Closed

Conversation

behnambagi
Copy link

@behnambagi behnambagi commented Jun 13, 2023

Fixes element-hq/element-web#25578


Here's what your changelog entry will look like:

🐛 Bug Fixes

@behnambagi behnambagi requested a review from a team as a code owner June 13, 2023 10:57
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jun 13, 2023
@behnambagi behnambagi changed the title fix bug in inviting users to a room #25578 fix bug in inviting users to a room Jun 13, 2023
@t3chguy
Copy link
Member

t3chguy commented Jun 14, 2023

See the contributing guide for the sign-off this PR requires

@alunturner
Copy link
Contributor

Hello! Thanks for the contribution. Firstly, to address the previous comment, the contribution guide can be seen here:
https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.md

Secondly, there's still some odd behaviour here. When I was testing the code changes you made (added onto the current develop branch) I found the below. The behaviour to me seems unchanged from your initial bug report, although there may be something I'm missing:

Screen.Recording.2023-06-21.at.09.20.24.mov

@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in inviting users to a room
3 participants