Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add E2E status in room header #11493

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 30, 2023

For element-hq/element-web#25883
Requires element-hq/element-web#26082 for tooltips to work

Screenshot 2023-08-30 at 15 45 10

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 30, 2023
@germain-gg germain-gg requested a review from a team as a code owner August 30, 2023 14:45
@germain-gg germain-gg requested review from andybalaam and dbkr August 30, 2023 14:45
@germain-gg germain-gg marked this pull request as draft August 30, 2023 14:45
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests, but I see you marked it as draft so maybe that's what you're working on.

Looks good otherwise!

src/components/views/rooms/RoomHeader.tsx Show resolved Hide resolved
Co-authored-by: Andy Balaam <andy.balaam@matrix.org>
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@germain-gg germain-gg enabled auto-merge August 31, 2023 10:28
@germain-gg germain-gg added this pull request to the merge queue Aug 31, 2023
Merged via the queue into develop with commit 46037d2 Aug 31, 2023
19 checks passed
@germain-gg germain-gg deleted the germain-gg/room-header-e2e-status branch August 31, 2023 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants