Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix flaky tests around editing messages #11652

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Fix flaky tests around editing messages #11652

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14a622b
Fix flaky test that assumes edits count as messages
andybalaam Sep 22, 2023
10eac43
Fix flaky test that raced because we were in the room while the count…
andybalaam Sep 22, 2023
25a462a
Fix lint error
andybalaam Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions cypress/e2e/read-receipts/editing-messages.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,21 +263,17 @@ describe("Read receipts", () => {
assertRead(room2);
});
it("A room where all edits are read is still read after restart", () => {
// Given an edit made the room unread
goTo(room2);
receiveMessages(room2, ["Msg1"]);
assertRead(room2);
receiveMessages(room2, [editOf("Msg1", "Msg1 Edit1")]);
// Given a message was edited and read
goTo(room1);
receiveMessages(room2, ["Msg1", editOf("Msg1", "Msg1 Edit1")]);
assertUnread(room2, 1);

// When I mark it as read
markAsRead(room2);

// Then the room becomes read
goTo(room2);
assertRead(room2);

// And remains so after a reload
// When I reload
saveAndReload();

// Then the room is still read
assertRead(room2);
});
});
Expand Down Expand Up @@ -371,7 +367,7 @@ describe("Read receipts", () => {
it("A room where all threaded edits are read is still read after restart", () => {
goTo(room2);
receiveMessages(room2, ["Msg1", threadedOff("Msg1", "Resp1"), editOf("Resp1", "Edit1")]);
assertUnread(room2, 2);
assertUnread(room2, 1);
openThread("Msg1");
assertRead(room2);
goTo(room1); // Make sure we are looking at room1 after reload
Expand Down
Loading