This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Fix multi-tab session lock on Firefox not being cleared #11800
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is new.
On balance, adding it is probably a good idea.
Previously I left the lockServicer in place, which would mean if the page came back to life, we would reclaim the lock. But that is racy: if we clear our claim, but the lockServicer fires again before the tab actually dies, we'll end up with a stuck claim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was my motivation - with the two handlers the risk to have a racy access might be higher. But I did not think about the page after being restored.
To close the bfache hole, couldn't we listen to
pageshow
withevent.persisted==true
and immediately re-start the lock servicer? But this might induce other problems, e.g.Maybe listening for
pageshow
withevent.persisted==true
and somehow forcing the session to be re-initialized would be better (or just reloading the whole app?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are no ideal solutions here. To be honest, my understanding is that the presence of an
unload
handler prevents the app being eligible for the bfcache anyway, so it's probably fine in practice. Longer term, the "right" solution is to fix multi-tab loading so we don't need any of this locking business (element-hq/element-web#26231).