Run Cypress on Rust crypto #11828
Run Cypress on Rust crypto #11828
Conversation
richvdh
added
the
T-Task
matrix-org/matrix-react-sdk#11828 removes the `rust-crypto` input param from the reusable cypress workflow. This gets rid of it on the calling side.
|
I don't think I've ever managed to get access to Kiwi, so I don't really know how it works, but I guess you're right. You're definitely right about the results artifact, anyway. Have done some stuff which seems like it might be plausible, but also requesting review from @michaelkaye since this touches Kiwi stuff. |
| @@ -84,7 +80,7 @@ jobs: | |||
| core.setOutput("email", response.data.author.email); | |||
|
|
|||
| # Only run Percy when it is demanded or we are running the daily build | |||
| - name: Enable Percy if X-Needs-Percy | |||
| - name: Enable Percy | |||
There was a problem hiding this comment.
incidentally: this "if X-Needs-Percy" was just a lie. Removed it as I don't think there is any particular benefit to repeating the exact conditions under which the step will run: as demonstrated, it is just a thing that we fail to maintain.
richvdh
force-pushed
the
rav/cypress-element-r
branch
from
c238dd0
to
20801c1
Compare
.github/workflows/cypress.yaml
Outdated
| @@ -289,5 +292,5 @@ jobs: | |||
| product: "Element Web" | |||
| product-version: ${{ github.event.workflow_run.head_branch }} | |||
| build-id: ${{ github.event.workflow_run.head_sha }} | |||
| suite-name: "Cypress E2E" | |||
| suite-name: "Cypress E2E (${{ matrix.crypto }} crypto)" | |||
There was a problem hiding this comment.
So actually i think we want this chnge on the build-id rather than the suite name; that would get us the same suite running against two versions (with/without rust) rather than two separate suites. Something like
Both suites will have the same tests in them so that shouldn't be a problem to have two builds going on here.
There was a problem hiding this comment.
@michaelkaye thanks. something like this? (eeffc8a)
... instead of test suite name
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matrix-org/matrix-react-sdk#11828 removes the `rust-crypto` input param from the reusable cypress workflow. This gets rid of it on the calling side.
Now that we have enabled Element-R on develop.element.io, it is particularly important that it keeps working. Let's try running Cypress on both crypto stacks.
This change is marked as an internal change (Task), so will not be included in the changelog.