This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Tell the timeline window when an event is removed (fixes element-web/issues/26498) #11836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Defect
Prevents element-hq/element-web#26498 (Can't remove a reaction from a thread) from happening, even when matrix-org/matrix-js-sdk#3798 (Move deleted messages into main timeline) is applied.
andybalaam
force-pushed
the
andybalaam/tell-window-when-event-is-removed
branch
from
3fe20b7
to
2965614
Compare
t3chguy
suggested changes
Nov 8, 2023
|
Re-done in matrix-org/matrix-js-sdk#3862 in a way that should work automatically for any user of the TimelineWindow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents element-hq/element-web#26498 (Can't remove a reaction from a thread) from happening, even when matrix-org/matrix-js-sdk#3798 (Move deleted messages into main timeline) is applied.
Here's what your changelog entry will look like:
🐛 Bug Fixes