This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use h1 as first heading in dialogs #12244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog should be modal and therefore the only content active on the screen, so the title of the dialog should be the top level.
dbkr
added
the
T-Defect
They were almost identical apart from the letter spacing
robintown
reviewed
Feb 13, 2024
res/css/_common.pcss
Outdated
| @@ -163,6 +163,7 @@ b { | |||
| font-weight: bold; | |||
| } | |||
|
|
|||
| h1, | |||
There was a problem hiding this comment.
Because letter-spacing is included in this declaration, I believe this is why things like the header on the onboarding page have changed their letter spacing. Probably the correct solution is to make sure .mx_Heading_h1 gets its own letter-spacing rule, to match the "heading XL semibold" font
robintown
reviewed
Feb 13, 2024
| @@ -33,6 +33,7 @@ limitations under the License. | |||
| .mx_Heading_h3 { | |||
| font: var(--cpd-font-heading-md-semibold); | |||
| font-weight: var(--cpd-font-weight-semibold); | |||
| letter-spacing: var(--cpd-font-letter-spacing-heading-lg); | |||
There was a problem hiding this comment.
So this was the letter spacing used for h2s so it's what makes them match what they were before. I'm also wondering why they're styled as h3s though - this might be what makes it odd.
|
This merge has gone terribly so I'm going to try again in a new branch. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog should be modal and therefore the only content active on the screen, so the title of the dialog should be the top level.
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes