This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add extra attribute to AccessibleButton
#12456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Task
t3chguy
reviewed
Apr 26, 2024
florianduros
force-pushed
the
florianduros/prepare-accessiblebutton
branch
from
1e310f0 to
fae6f50
Compare
t3chguy
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of element-hq/element-web#26762
Prepare work for #12448 (it will be splitted in many PRs)
I will need this extra attributes for
AccessibleButtonfor the migration fromAccessibleTooltipButton.TLDR: Add new attribute to prepare the incoming migration to from
AccessibleTooltipButtontoAccessibleButtonAlso, the
triggerInteractivecreates unwanted extra span in the dom.