Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Convert UserSettings to functional component #12474

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Convert UserSettings to functional component #12474

merged 4 commits into from
Apr 30, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 30, 2024

Also converts the settings to useSetting so they're not computed on every render. In advance of changing the headers.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 30, 2024
@dbkr dbkr marked this pull request as ready for review April 30, 2024 18:39
@dbkr dbkr requested a review from a team as a code owner April 30, 2024 18:39
@dbkr dbkr requested review from t3chguy and robintown April 30, 2024 18:39
@dbkr dbkr added this pull request to the merge queue Apr 30, 2024
Merged via the queue into develop with commit 906c9dd Apr 30, 2024
30 checks passed
@dbkr dbkr deleted the dbkr/settings_functionalcomponent branch April 30, 2024 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbkr @t3chguy @robintown